feat: ipfs metadata provider #5
Conversation
| } catch (error: unknown) { | ||
| if (error instanceof InvalidContentException) throw error; | ||
|
|
||
| if (axios.isAxiosError(error)) { | ||
| console.warn(`Failed to fetch from ${url}: ${error.message}`); | ||
| } else { | ||
| console.error(`Failed to fetch from ${url}: ${error}`); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| console.error(`Failed to fetch IPFS data for CID ${ipfsCid} from all gateways.`); | ||
| return undefined; |
There was a problem hiding this comment.
Here we need a tailored error handling
- Non existent content should return undefined
- Network and other errors should retry
There was a problem hiding this comment.
Open question: Could it happen that some content of a cid exist in one gateway and not in other ?
In other words, can we be sure that a cid content doesn't exist in some way ?
There was a problem hiding this comment.
that's an interesting question, i have to research since i don't know much about IPFS
regarding the first:
- non existent returns undefined after checking and failing on all the gateways
- yeah totally, i left a TODO for working the retry policy
There was a problem hiding this comment.
tldr; it's possible that a CID "exists" on one gateway and not on another if the content hasn't propagated to the node corresponding to that gateway:
https://www.perplexity.ai/search/you-re-an-expert-on-ipfs-and-i-WA60t4oLT46rc1yZySnJkg
| throw new InvalidCidException(ipfsCid); | ||
| } | ||
|
|
||
| for (const gateway of this.gateways) { |
There was a problem hiding this comment.
Not sure if latency here is super important but, if it is, have you considered using Promise.any? You'll always be triggering N requests but resolving with the first successful one, instead of calling them sequentially until one of them succeeds.
It could be also helpful to quickly handle non-existant CIDs if, for some reason, you expect working with non-existant CIDs.
There was a problem hiding this comment.
that could be super helpful but maybe at the same time we exhaust all of the gateways when not needed to 🤔 , like i said to kenji, i will read more about IPFS cuz i know little
There was a problem hiding this comment.
will go back into this analysis when implementing the retry policy, for now we keep this simpler solution for the MVP
🤖 Linear
Closes GIT-65
Description
metadatapackage with IpfsProviderChecklist before requesting a review